Commit 2498e29
src: Revert "nix stdin _readableState.reading"
This reverts 8cee8f5 which was causing stdin to behave strangely on
Windows 8 and 10. The suspected explanation for the issue is that there
might be a race condition occuring when stdin._readableState.reading is
set indirectly through `push('')`.
PR-URL: #3490
Fixes: #2996
Fixes: #2504
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>1 parent b663d2b commit 2498e29
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -726,7 +726,7 @@ | |||
| 726 | 726 | // not-reading state. | |
| 727 | 727 | if (stdin._handle && stdin._handle.readStop) { | |
| 728 | 728 | stdin._handle.reading = false; | |
| 729 | - stdin.push(''); | ||
| 729 | + stdin._readableState.reading = false; | ||
| 730 | 730 | stdin._handle.readStop(); | |
| 731 | 731 | } | |
| 732 | 732 | ||
@@ -735,7 +735,7 @@ | |||
| 735 | 735 | stdin.on('pause', function() { | |
| 736 | 736 | if (!stdin._handle) | |
| 737 | 737 | return; | |
| 738 | - stdin.push(''); | ||
| 738 | + stdin._readableState.reading = false; | ||
| 739 | 739 | stdin._handle.reading = false; | |
| 740 | 740 | stdin._handle.readStop(); | |
| 741 | 741 | }); | |
0 commit comments