fs: fix fs.promises.realpath for long paths on Windows · nodejs/node@25056f5 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 634
• Pull requests 749
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 25056f5

Browse filesBrowse the repository at this point in the historyBrowse files

sapphi-red

authored and

richardlau

committed

fs: fix fs.promises.realpath for long paths on Windows

Unlike other fs functions that work with paths, realpath isn't using pathModule.toNamespacedPath prior to calling libuv function. This is causing issues on windows. Windows long path test is also improved to cover the mentioned issue. Fixes: #51031 PR-URL: #51032 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 42b162b commit 25056f5
Copy full SHA for 25056f5

2 files changed

+4-1Lines changed: 4 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/fs
  • promises.js
• test/parallel
  • test-fs-long-path.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/fs/promises.js‎

Copy file name to clipboardExpand all lines: lib/internal/fs/promises.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1010,7 +1010,7 @@ async function lutimes(path, atime, mtime) {
1010	1010	async function realpath(path, options) {
1011	1011	options = getOptions(options);
1012	1012	path = getValidatedPath(path);
1013		- return binding.realpath(path, options.encoding, kUsePromises);
	1013	+ return binding.realpath(pathModule.toNamespacedPath(path), options.encoding, kUsePromises);
1014	1014	}
1015	1015
1016	1016	async function mkdtemp(prefix, options) {

Collapse file

‎test/parallel/test-fs-long-path.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-long-path.js

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -46,4 +46,7 @@ fs.writeFile(fullPath, 'ok', common.mustSucceed(() => {
46	46
47	47	// Tests https://github.com/nodejs/node/issues/39721
48	48	fs.realpath.native(fullPath, common.mustSucceed());
	49	+
	50	+ // Tests https://github.com/nodejs/node/issues/51031
	51	+ fs.promises.realpath(fullPath).then(common.mustCall(), common.mustNotCall());
49	52	}));

0 commit comments

Comments

0 (0)