Commit 259f2d3
test: remove fixturesDir from common module
Remove common.fixturesDir. All tests now use the the common/fixtures
module instead.
PR-URL: #17400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent 92b29cd commit 259f2d3
2 files changed
Lines changed: 1 addition & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -127,11 +127,6 @@ Returns a new promise that will propagate `promise` resolution or rejection if | |||
| 127 | 127 | that happens within the `timeoutMs` timespan, or rejects with `error` as | |
| 128 | 128 | a reason otherwise. | |
| 129 | 129 | ||
| 130 | - ### fixturesDir | ||
| 131 | - * [<String>] | ||
| 132 | - | ||
| 133 | - Path to the 'fixtures' directory. | ||
| 134 | - | ||
| 135 | 130 | ### getArrayBufferViews(buf) | |
| 136 | 131 | * `buf` [<Buffer>] | |
| 137 | 132 | * return [<ArrayBufferView[]>] | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,8 +36,6 @@ const testRoot = process.env.NODE_TEST_DIR ? | |||
| 36 | 36 | ||
| 37 | 37 | const noop = () => {}; | |
| 38 | 38 | ||
| 39 | - exports.fixturesDir = fixturesDir; | ||
| 40 | - | ||
| 41 | 39 | // Using a `.` prefixed name, which is the convention for "hidden" on POSIX, | |
| 42 | 40 | // gets tools to ignore it by default or by simple rules, especially eslint. | |
| 43 | 41 | let tmpDirName = '.tmp'; | |
@@ -303,7 +301,7 @@ exports.childShouldThrowAndAbort = function() { | |||
| 303 | 301 | ||
| 304 | 302 | exports.ddCommand = function(filename, kilobytes) { | |
| 305 | 303 | if (exports.isWindows) { | |
| 306 | - const p = path.resolve(exports.fixturesDir, 'create-file.js'); | ||
| 304 | + const p = path.resolve(fixturesDir, 'create-file.js'); | ||
| 307 | 305 | return `"${process.argv[0]}" "${p}" "${filename}" ${kilobytes * 1024}`; | |
| 308 | 306 | } else { | |
| 309 | 307 | return `dd if=/dev/zero of="${filename}" bs=1024 count=${kilobytes}`; | |
0 commit comments