Commit 25bb462
deps: define V8_PRESERVE_MOST as no-op on Windows
It's causing linker errors with node.lib in node-gyp and potentially
breaks other 3rd party tools
PR-URL: #56238
Refs: #55784
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 0d08756 commit 25bb462
2 files changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.11', | ||
| 39 | + 'v8_embedder_string': '-node.12', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -581,11 +581,15 @@ path. Add it with -I<path> to the command line | |||
| 581 | 581 | // functions. | |
| 582 | 582 | // Use like: | |
| 583 | 583 | // V8_NOINLINE V8_PRESERVE_MOST void UnlikelyMethod(); | |
| 584 | + #if V8_OS_WIN | ||
| 585 | + # define V8_PRESERVE_MOST | ||
| 586 | + #else | ||
| 584 | 587 | #if V8_HAS_ATTRIBUTE_PRESERVE_MOST | |
| 585 | 588 | # define V8_PRESERVE_MOST __attribute__((preserve_most)) | |
| 586 | 589 | #else | |
| 587 | 590 | # define V8_PRESERVE_MOST /* NOT SUPPORTED */ | |
| 588 | 591 | #endif | |
| 592 | + #endif | ||
| 589 | 593 | ||
| 590 | 594 | ||
| 591 | 595 | // A macro (V8_DEPRECATED) to mark classes or functions as deprecated. | |
0 commit comments