Commit 25c79f3
esm: drop support for import assertions
This patch removes support for the `assert` keyword
for import attributes. It was an old variant of the
proposal that was only shipped in V8 and no other
engine, and that has then been replaced by the `with`
keyword.
Chrome is planning to remove support for `assert`
in version 126, which will be released in June.
Node.js already supports the `with` keyword for
import attributes, and this patch does not change that.
PR-URL: #52104
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>1 parent 4a6ca7a commit 25c79f3
3 files changed
Lines changed: 23 additions & 6 deletions
File tree
- src
- test/es-module
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -800,19 +800,16 @@ static ExitCode ProcessGlobalArgsInternal(std::vector<std::string>* args, | |||
| 800 | 800 | return ExitCode::kInvalidCommandLineArgument2; | |
| 801 | 801 | } | |
| 802 | 802 | ||
| 803 | - // TODO(aduh95): remove this when the harmony-import-assertions flag | ||
| 804 | - // is removed in V8. | ||
| 805 | - if (std::find(v8_args.begin(), v8_args.end(), | ||
| 806 | - "--no-harmony-import-assertions") == v8_args.end()) { | ||
| 807 | - v8_args.emplace_back("--harmony-import-assertions"); | ||
| 808 | - } | ||
| 809 | 803 | // TODO(aduh95): remove this when the harmony-import-attributes flag | |
| 810 | 804 | // is removed in V8. | |
| 811 | 805 | if (std::find(v8_args.begin(), | |
| 812 | 806 | v8_args.end(), | |
| 813 | 807 | "--no-harmony-import-attributes") == v8_args.end()) { | |
| 814 | 808 | v8_args.emplace_back("--harmony-import-attributes"); | |
| 815 | 809 | } | |
| 810 | + // TODO(nicolo-ribaudo): remove this once V8 doesn't enable it by default | ||
| 811 | + // anymore. | ||
| 812 | + v8_args.emplace_back("--no-harmony-import-assertions"); | ||
| 816 | 813 | ||
| 817 | 814 | auto env_opts = per_process::cli_options->per_isolate->per_env; | |
| 818 | 815 | if (std::find(v8_args.begin(), v8_args.end(), | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -55,6 +55,16 @@ async function test() { | |||
| 55 | 55 | import(jsonModuleDataUrl, { with: { type: 'unsupported' } }), | |
| 56 | 56 | { code: 'ERR_IMPORT_ATTRIBUTE_UNSUPPORTED' } | |
| 57 | 57 | ); | |
| 58 | + | ||
| 59 | + await rejects( | ||
| 60 | + import(jsonModuleDataUrl, { assert: { type: 'json' } }), | ||
| 61 | + { code: 'ERR_IMPORT_ATTRIBUTE_MISSING' } | ||
| 62 | + ); | ||
| 63 | + | ||
| 64 | + await rejects( | ||
| 65 | + import(`data:text/javascript,import${JSON.stringify(jsonModuleDataUrl)}assert{type:"json"}`), | ||
| 66 | + SyntaxError | ||
| 67 | + ); | ||
| 58 | 68 | } | |
| 59 | 69 | ||
| 60 | 70 | test().then(common.mustCall()); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -50,3 +50,13 @@ await rejects( | |||
| 50 | 50 | import(jsonModuleDataUrl, { with: { type: 'unsupported' } }), | |
| 51 | 51 | { code: 'ERR_IMPORT_ATTRIBUTE_UNSUPPORTED' } | |
| 52 | 52 | ); | |
| 53 | + | ||
| 54 | + await rejects( | ||
| 55 | + import(jsonModuleDataUrl, { assert: { type: 'json' } }), | ||
| 56 | + { code: 'ERR_IMPORT_ATTRIBUTE_MISSING' } | ||
| 57 | + ); | ||
| 58 | + | ||
| 59 | + await rejects( | ||
| 60 | + import(`data:text/javascript,import${JSON.stringify(jsonModuleDataUrl)}assert{type:"json"}`), | ||
| 61 | + SyntaxError | ||
| 62 | + ); | ||
0 commit comments