lib: runtime deprecate access to process.binding('http_parser') · nodejs/node@25e3000 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 25e3000

Browse filesBrowse the repository at this point in the historyBrowse files

jasnell

committed

lib: runtime deprecate access to process.binding('http_parser')

The internal HTTP Parser constructor and methods list are available via `require('_http_parser')`, there's no need for the ecosystem to access via `process.binding()` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37813 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

1 parent 8bb4e04 commit 25e3000
Copy full SHA for 25e3000

1 file changed

+1Lines changed: 1 addition & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/bootstrap
  • loaders.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/bootstrap/loaders.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/loaders.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -109,6 +109,7 @@ const internalBindingAllowlist = new SafeSet([
109	109	const runtimeDeprecatedList = new SafeSet([
110	110	'async_wrap',
111	111	'crypto',
	112	+ 'http_parser',
112	113	'signal_wrap',
113	114	'url',
114	115	'v8',

0 commit comments

Comments

0 (0)