| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent 9ec0eab commit 27088cf
2 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -469,10 +469,11 @@ $ npm install -g node-core-utils | |||
| 469 | 469 | $ git node land $PRID | |
| 470 | 470 | ``` | |
| 471 | 471 | ||
| 472 | - If it's the first time you ever use `node-core-utils`, you will be prompted | ||
| 473 | - to type the password of your GitHub account in the console so the tool can | ||
| 474 | - create the GitHub access token for you. If you do not want to do that, follow | ||
| 475 | - [the guide of `node-core-utils`][node-core-utils-credentials] | ||
| 472 | + If it's the first time you have used `node-core-utils`, you will be prompted | ||
| 473 | + to type the password of your GitHub account and the two-factor authentication | ||
| 474 | + code in the console so the tool can create the GitHub access token for you. | ||
| 475 | + If you do not want to do that, follow | ||
| 476 | + [the `node-core-utils` guide][node-core-utils-credentials] | ||
| 476 | 477 | to set up your credentials manually. | |
| 477 | 478 | ||
| 478 | 479 | ### Technical HOWTO | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,16 +6,21 @@ onboarding session. | |||
| 6 | 6 | ## One week before the onboarding session | |
| 7 | 7 | ||
| 8 | 8 | * If the new Collaborator is not yet a member of the nodejs GitHub organization, | |
| 9 | - confirm that they are using two-factor authentication. It will not be possible | ||
| 10 | - to add them to the organization if they are not using two-factor | ||
| 11 | - authentication. | ||
| 9 | + confirm that they are using [two-factor authentication][]. It will not be | ||
| 10 | + possible to add them to the organization if they are not using two-factor | ||
| 11 | + authentication. If they cannot receive SMS messages from GitHub, try | ||
| 12 | + [using a TOTP mobile app][]. | ||
| 12 | 13 | * Announce the accepted nomination in a TSC meeting and in the TSC | |
| 13 | 14 | mailing list. | |
| 15 | + * Suggest the new Collaborator install [`node-core-utils`][] and | ||
| 16 | + [set up the credentials][] for it. | ||
| 14 | 17 | ||
| 15 | 18 | ## Fifteen minutes before the onboarding session | |
| 16 | 19 | ||
| 17 | 20 | * Prior to the onboarding session, add the new Collaborator to | |
| 18 | 21 | [the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators). | |
| 22 | + * Ask them if they want to join any subsystem teams. See | ||
| 23 | + [Who to CC for Issues][who-to-cc]. | ||
| 19 | 24 | ||
| 20 | 25 | ## Onboarding session | |
| 21 | 26 | ||
@@ -87,7 +92,7 @@ onboarding session. | |||
| 87 | 92 | * When adding a `semver-*` label, add a comment explaining why you're adding | |
| 88 | 93 | it. Do it right away so you don't forget! | |
| 89 | 94 | ||
| 90 | - * [**See "Who to CC in issues"**](./onboarding-extras.md#who-to-cc-in-issues) | ||
| 95 | + * [**See "Who to CC in issues"**][who-to-cc] | ||
| 91 | 96 | * This will come more naturally over time | |
| 92 | 97 | * For many of the teams listed there, you can ask to be added if you are | |
| 93 | 98 | interested | |
@@ -183,7 +188,13 @@ onboarding session. | |||
| 183 | 188 | ||
| 184 | 189 | ## Landing PRs | |
| 185 | 190 | ||
| 186 | - * See the Collaborator Guide: [Landing Pull Requests][] | ||
| 191 | + See the Collaborator Guide: [Landing Pull Requests][]. | ||
| 192 | + | ||
| 193 | + Note that commits in one PR that belong to one logical change should | ||
| 194 | + be squashed. It is rarely the case in onboarding exercises, so this | ||
| 195 | + needs to be pointed out separately during the onboarding. | ||
| 196 | + | ||
| 197 | + <!-- TODO(joyeechueng): provide examples about "one logical change" --> | ||
| 187 | 198 | ||
| 188 | 199 | ## Exercise: Make a PR adding yourself to the README | |
| 189 | 200 | ||
@@ -202,9 +213,11 @@ onboarding session. | |||
| 202 | 213 | for 48/72 hours to land). | |
| 203 | 214 | * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` | |
| 204 | 215 | metadata. | |
| 205 | - * [`core-validate-commit`][] automates the validation of commit messages. | ||
| 206 | 216 | * [`node-core-utils`][] automates the generation of metadata and the landing | |
| 207 | 217 | process. See the documentation of [`git-node`][]. | |
| 218 | + * [`core-validate-commit`][] automates the validation of commit messages. | ||
| 219 | + This will be run during `git node land --final` of the [`git-node`][] | ||
| 220 | + command. | ||
| 208 | 221 | ||
| 209 | 222 | ## Final notes | |
| 210 | 223 | ||
@@ -227,9 +240,13 @@ onboarding session. | |||
| 227 | 240 | ||
| 228 | 241 | [Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md | |
| 229 | 242 | [`core-validate-commit`]: https://github.com/evanlucas/core-validate-commit | |
| 230 | - [`git-node`]: https://github.com/nodejs/node-core-utils#git-node | ||
| 243 | + [`git-node`]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md | ||
| 231 | 244 | [`node-core-utils`]: https://github.com/nodejs/node-core-utils | |
| 232 | 245 | [Landing Pull Requests]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests | |
| 233 | 246 | [https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0]: https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0 | |
| 234 | 247 | [Publicizing or hiding organization membership]: https://help.github.com/articles/publicizing-or-hiding-organization-membership/ | |
| 248 | + [set up the credentials]: https://github.com/nodejs/node-core-utils#setting-up-credentials | ||
| 249 | + [two-factor authentication]: https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/ | ||
| 235 | 250 | [Updating Node.js from Upstream]: ./onboarding-extras.md#updating-nodejs-from-upstream | |
| 251 | + [using a TOTP mobile app]: https://help.github.com/articles/configuring-two-factor-authentication-via-a-totp-mobile-app/ | ||
| 252 | + [who-to-cc]: ./onboarding-extras.md#who-to-cc-in-issues | ||
| Back | FazBrowse Home | New Git URL |
0 commit comments