Commit 273e02d
doc: add missing make command to UPGRADING.md
Added the missing make command in steps 6.3 when building
asm_obsolete.
Also updated the commit message to include the version nasm in
addition to the gcc version.
Fixes: #13161
Backport-PR-URL: #13696
PR-URL: #13233
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent 84a838e commit 273e02d
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -346,13 +346,16 @@ ohtsu@ubuntu:~/github/node/deps/openssl/asm_obsolete$ make clean | |||
| 346 | 346 | find . -iname '*.asm' -exec rm "{}" \; | |
| 347 | 347 | find . -iname '*.s' -exec rm "{}" \; | |
| 348 | 348 | find . -iname '*.S' -exec rm "{}" \; | |
| 349 | + ohtsu@ubuntu:~/github/node/deps/openssl/asm_obsolete$ make | ||
| 349 | 350 | ohtsu@ubuntu:~/github/node/deps/openssl$ git status | |
| 350 | 351 | ohtsu@ubuntu:~/github/node/deps/openssl$ git commit asm asm_obsolete | |
| 351 | 352 | ```` | |
| 352 | 353 | The commit message can be | |
| 353 | 354 | ||
| 354 | 355 | >deps: update openssl asm and asm_obsolete files | |
| 355 | 356 | > | |
| 356 | - >Regenerate asm files with Makefile and CC=gcc and ASM=gcc where | ||
| 357 | - >gcc-4.8.4. Also asm files in asm_obsolete dir to support old compiler | ||
| 358 | - >and assembler are regenerated without CC and ASM envs. | ||
| 357 | + >Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc | ||
| 358 | + >version was 5.4.0 and nasm version was 2.11.08. | ||
| 359 | + > | ||
| 360 | + >Also asm files in asm_obsolete dir to support old compiler and | ||
| 361 | + >assembler are regenerated without CC and ASM envs. | ||
0 commit comments