crypto: clarify `require("crypto").getRandomValues` is Node.js specific · nodejs/node@288f627 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 634
• Pull requests 592
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 288f627

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

sxa

committed

crypto: clarify require("crypto").getRandomValues is Node.js specific

Refs: #41779 Refs: #41760 PR-URL: #41782 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

1 parent 0ce00ca commit 288f627
Copy full SHA for 288f627

2 files changed

+8-2Lines changed: 8 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • crypto.md
• lib
  • crypto.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/crypto.md‎

Copy file name to clipboardExpand all lines: doc/api/crypto.md

+3-1Lines changed: 3 additions & 1 deletion

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -4104,7 +4104,9 @@ added: v17.4.0
4104	4104	* `typedArray` {Buffer|TypedArray|DataView|ArrayBuffer}
4105	4105	* Returns: {Buffer|TypedArray|DataView|ArrayBuffer} Returns `typedArray`.
4106	4106
4107		- A convenient alias for [`crypto.webcrypto.getRandomValues()`][].
	4107	+ A convenient alias for [`crypto.webcrypto.getRandomValues()`][]. This
	4108	+ implementation is not compliant with the Web Crypto spec, to write
	4109	+ web-compatible code use [`crypto.webcrypto.getRandomValues()`][] instead.
4108	4110
4109	4111	### `crypto.hkdf(digest, ikm, salt, info, keylen, callback)`
4110	4112

Collapse file

‎lib/crypto.js‎

Copy file name to clipboardExpand all lines: lib/crypto.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -252,6 +252,10 @@ function getFipsForced() {
252	252	return 1;
253	253	}
254	254
	255	+ function getRandomValues(array) {
	256	+ return lazyWebCrypto().crypto.getRandomValues(array);
	257	+ }
	258	+
255	259	ObjectDefineProperty(constants, 'defaultCipherList', {
256	260	value: getOptionValue('--tls-cipher-list')
257	261	});
@@ -303,7 +307,7 @@ ObjectDefineProperties(module.exports, {
303	307	getRandomValues: {
304	308	configurable: false,
305	309	enumerable: true,
306		- get() { return lazyWebCrypto().crypto.getRandomValues; },
	310	+ get: () => getRandomValues,
307	311	set: undefined,
308	312	},
309	313

0 commit comments

Comments

0 (0)