Commit 2893b4c
build: check if python is a executable program
After Windows 10 version 1903, placeholder files named "python.exe"
and "python3.exe" appear, not executable programs, and open the
MS Store when running without parameters.
Fixes: #36694
Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update
PR-URL: #36696
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent e1e059a commit 2893b4c
1 file changed
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -46,6 +46,8 @@ exit /b 1 | |||
| 46 | 46 | ||
| 47 | 47 | :found-python | |
| 48 | 48 | echo Python found in %p%\python.exe | |
| 49 | + call :check-python %p%\python.exe | ||
| 50 | + if errorlevel 1 goto :no-python | ||
| 49 | 51 | endlocal ^ | |
| 50 | 52 | & set "pt=%p%" ^ | |
| 51 | 53 | & set "need_path_ext=%need_path%" | |
@@ -54,6 +56,15 @@ set "pt=" | |||
| 54 | 56 | set "need_path_ext=" | |
| 55 | 57 | exit /b 0 | |
| 56 | 58 | ||
| 59 | + :check-python | ||
| 60 | + %~1 -V | ||
| 61 | + :: 9009 means error file not found | ||
| 62 | + if %errorlevel% equ 9009 ( | ||
| 63 | + echo Not an executable Python program | ||
| 64 | + exit /b 1 | ||
| 65 | + ) | ||
| 66 | + exit /b 0 | ||
| 67 | + | ||
| 57 | 68 | :no-python | |
| 58 | 69 | echo Could not find Python. | |
| 59 | 70 | exit /b 1 | |
0 commit comments