Commit 28b7bf0
deps: cherry-pick b8331cc030 from upstream V8
Original commit message:
I believe the paths to the V8 include headers are incorrect. The
paths to other sources seem to be relative to the parent directory.
When building Node.js I get the following warning on Windows:
Warning: Missing input files:
deps\v8\src\..\..\include\v8-inspector-protocol.h
deps\v8\src\..\..\include\v8-inspector.h
This commit updates the two include paths.
Bug:
Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f
Reviewed-on: https://chromium-review.googlesource.com/743981
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49121}
This commit also increments the v8_embedder_string version.
PR-URL: #16900
Fixes: #16614
Refs: v8/v8@b8331cc
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent 8611e3b commit 28b7bf0
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -27,7 +27,7 @@ | |||
| 27 | 27 | ||
| 28 | 28 | # Reset this number to 0 on major V8 upgrades. | |
| 29 | 29 | # Increment by one for each non-official patch applied to deps/v8. | |
| 30 | - 'v8_embedder_string': '-node.8', | ||
| 30 | + 'v8_embedder_string': '-node.9', | ||
| 31 | 31 | ||
| 32 | 32 | # Enable disassembler for `--print-code` v8 options | |
| 33 | 33 | 'v8_enable_disassembler': 1, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -31,8 +31,8 @@ | |||
| 31 | 31 | 'inspector_all_sources': [ | |
| 32 | 32 | '<@(inspector_generated_sources)', | |
| 33 | 33 | '<(inspector_generated_injected_script)', | |
| 34 | - '../../include/v8-inspector.h', | ||
| 35 | - '../../include/v8-inspector-protocol.h', | ||
| 34 | + '../include/v8-inspector.h', | ||
| 35 | + '../include/v8-inspector-protocol.h', | ||
| 36 | 36 | 'inspector/injected-script.cc', | |
| 37 | 37 | 'inspector/injected-script.h', | |
| 38 | 38 | 'inspector/inspected-context.cc', | |
0 commit comments