Commit 28f662b
build: check FIPS option value in node.gyp
openssl_is_fips is always the string "true" or "false", so testing
whether it is non-empty always adds OPENSSL_FIPS to mkssldef. Add the
define only when FIPS was requested.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64982
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Aviv Keller <me@aviv.sh>1 parent 29a2ece commit 28f662b
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1032,7 +1032,7 @@ | |||
| 1032 | 1032 | ], | |
| 1033 | 1033 | }, | |
| 1034 | 1034 | 'conditions': [ | |
| 1035 | - ['openssl_is_fips!=""', { | ||
| 1035 | + ['openssl_is_fips=="true"', { | ||
| 1036 | 1036 | 'variables': { 'mkssldef_flags': ['-DOPENSSL_FIPS'] }, | |
| 1037 | 1037 | }], | |
| 1038 | 1038 | ], | |
0 commit comments