Commit 297cb0d
doc: tweak onboarding instructions
Add some additional guidance based on something we missed
in a recent onboarding step.
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #55212
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Abdirahim Musse <abdirahim.musse@ibm.com>1 parent 1b30f7f commit 297cb0d
1 file changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -216,6 +216,13 @@ needs to be pointed out separately during the onboarding. | |||
| 216 | 216 | `git show --format=%B 6669b3857f0f43ee0296eb7ac45086cd907b9e94` | |
| 217 | 217 | * Collaborators are in alphabetical order by GitHub username. | |
| 218 | 218 | * Optionally, include your personal pronouns. | |
| 219 | + * The PR should include an addition to the | ||
| 220 | + [mailmap](.mailmap) file if the email | ||
| 221 | + being added to the collaborator list does not match the email used for | ||
| 222 | + commits. Otherwise tooling will not see the collaborator as being active and | ||
| 223 | + may suggest removing them. See | ||
| 224 | + [gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the | ||
| 225 | + format of the mailmap file. | ||
| 219 | 226 | * Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message | |
| 220 | 227 | so that when the commit lands, the nomination issue url will be | |
| 221 | 228 | automatically closed. | |
0 commit comments