Commit 29f010f
test: fix Linux debug skip in SEA test guard
process.config.variables.is_debug is only populated by the GN build
flow (tools/generate_config_gypi.py), so on the gyp builds used by CI
the guard never fired and SEA tests ran on Linux debug builds against
the original intent. Switch to
process.config.target_defaults.default_configuration === 'Debug',
matching the pattern used in test/common/index.js.
Fixes: #63749
Refs: #61483
Signed-off-by: Hyunwoo Gu <realization0327@gmail.com>
PR-URL: #63751
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent fda8ee8 commit 29f010f
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -27,7 +27,7 @@ function skipIfSingleExecutableIsNotSupported() { | |||
| 27 | 27 | if (!['darwin', 'win32', 'linux'].includes(process.platform)) | |
| 28 | 28 | common.skip(`Unsupported platform ${process.platform}.`); | |
| 29 | 29 | ||
| 30 | - if (process.platform === 'linux' && process.config.variables.is_debug === 1) | ||
| 30 | + if (process.platform === 'linux' && common.isDebug) | ||
| 31 | 31 | common.skip('Running the resultant binary fails with `Couldn\'t read target executable"`.'); | |
| 32 | 32 | ||
| 33 | 33 | if (process.config.variables.node_shared) | |
0 commit comments