Commit 2a53165
committed
test: add missing assertion
This commit adds an assertion to an existing try...catch
statement. Unfortunately, assert.throws() cannot be used
because the operation succeeds on some platforms, throws
EINVAL on some platforms, and throws ENOPROTOOPT on
others.
PR-URL: #15519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent db8c92f commit 2a53165
1 file changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -33,11 +33,14 @@ const dgram = require('dgram'); | |||
| 33 | 33 | socket.bind(0); | |
| 34 | 34 | socket.on('listening', common.mustCall(() => { | |
| 35 | 35 | // Try to set with an invalid interfaceAddress (wrong address class) | |
| 36 | + // | ||
| 37 | + // This operation succeeds on some platforms, throws `EINVAL` on some | ||
| 38 | + // platforms, and throws `ENOPROTOOPT` on others. This is unpleasant, but | ||
| 39 | + // we should at least test for it. | ||
| 36 | 40 | try { | |
| 37 | 41 | socket.setMulticastInterface('::'); | |
| 38 | - throw new Error('Not detected.'); | ||
| 39 | 42 | } catch (e) { | |
| 40 | - console.error(`setMulticastInterface: wrong family error is: ${e}`); | ||
| 43 | + assert(e.code === 'EINVAL' || e.code === 'ENOPROTOOPT'); | ||
| 41 | 44 | } | |
| 42 | 45 | ||
| 43 | 46 | socket.close(); | |
0 commit comments