Commit 2ab33c5
buffer: also alias BigUInt methods
These were overlooked in 5864fca because of the extra
`Big` in the name. :)
Refs: #34729
PR-URL: #34960
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 9aba579 commit 2ab33c5
3 files changed
Lines changed: 22 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1379,6 +1379,10 @@ values. | |||
| 1379 | 1379 | added: | |
| 1380 | 1380 | - v12.0.0 | |
| 1381 | 1381 | - v10.20.0 | |
| 1382 | + changes: | ||
| 1383 | + - version: REPLACEME | ||
| 1384 | + pr-url: https://github.com/nodejs/node/pull/34960 | ||
| 1385 | + description: This function is also available as `buf.readBigUint64BE()`. | ||
| 1382 | 1386 | --> | |
| 1383 | 1387 | ||
| 1384 | 1388 | * `offset` {integer} Number of bytes to skip before starting to read. Must | |
@@ -1400,6 +1404,10 @@ console.log(buf.readBigUInt64BE(0)); | |||
| 1400 | 1404 | added: | |
| 1401 | 1405 | - v12.0.0 | |
| 1402 | 1406 | - v10.20.0 | |
| 1407 | + changes: | ||
| 1408 | + - version: REPLACEME | ||
| 1409 | + pr-url: https://github.com/nodejs/node/pull/34960 | ||
| 1410 | + description: This function is also available as `buf.readBigUint64LE()`. | ||
| 1403 | 1411 | --> | |
| 1404 | 1412 | ||
| 1405 | 1413 | * `offset` {integer} Number of bytes to skip before starting to read. Must | |
@@ -2304,6 +2312,10 @@ console.log(buf); | |||
| 2304 | 2312 | added: | |
| 2305 | 2313 | - v12.0.0 | |
| 2306 | 2314 | - v10.20.0 | |
| 2315 | + changes: | ||
| 2316 | + - version: REPLACEME | ||
| 2317 | + pr-url: https://github.com/nodejs/node/pull/34960 | ||
| 2318 | + description: This function is also available as `buf.writeBigUint64BE()`. | ||
| 2307 | 2319 | --> | |
| 2308 | 2320 | ||
| 2309 | 2321 | * `value` {bigint} Number to be written to `buf`. | |
@@ -2327,6 +2339,10 @@ console.log(buf); | |||
| 2327 | 2339 | added: | |
| 2328 | 2340 | - v12.0.0 | |
| 2329 | 2341 | - v10.20.0 | |
| 2342 | + changes: | ||
| 2343 | + - version: REPLACEME | ||
| 2344 | + pr-url: https://github.com/nodejs/node/pull/34960 | ||
| 2345 | + description: This function is also available as `buf.writeBigUint64LE()`. | ||
| 2330 | 2346 | --> | |
| 2331 | 2347 | ||
| 2332 | 2348 | * `value` {bigint} Number to be written to `buf`. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -951,10 +951,14 @@ class FastBuffer extends Uint8Array {} | |||
| 951 | 951 | function addBufferPrototypeMethods(proto) { | |
| 952 | 952 | proto.readBigUInt64LE = readBigUInt64LE, | |
| 953 | 953 | proto.readBigUInt64BE = readBigUInt64BE, | |
| 954 | + proto.readBigUint64LE = readBigUInt64LE, | ||
| 955 | + proto.readBigUint64BE = readBigUInt64BE, | ||
| 954 | 956 | proto.readBigInt64LE = readBigInt64LE, | |
| 955 | 957 | proto.readBigInt64BE = readBigInt64BE, | |
| 956 | 958 | proto.writeBigUInt64LE = writeBigUInt64LE, | |
| 957 | 959 | proto.writeBigUInt64BE = writeBigUInt64BE, | |
| 960 | + proto.writeBigUint64LE = writeBigUInt64LE, | ||
| 961 | + proto.writeBigUint64BE = writeBigUInt64BE, | ||
| 958 | 962 | proto.writeBigInt64LE = writeBigInt64LE, | |
| 959 | 963 | proto.writeBigInt64BE = writeBigInt64BE, | |
| 960 | 964 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -222,7 +222,8 @@ const assert = require('assert'); | |||
| 222 | 222 | } | |
| 223 | 223 | ||
| 224 | 224 | for (const fn of [ | |
| 225 | - 'UInt8', 'UInt16LE', 'UInt16BE', 'UInt32LE', 'UInt32BE', 'UIntLE', 'UIntBE' | ||
| 225 | + 'UInt8', 'UInt16LE', 'UInt16BE', 'UInt32LE', 'UInt32BE', 'UIntLE', 'UIntBE', | ||
| 226 | + 'BigUInt64LE', 'BigUInt64BE', | ||
| 226 | 227 | ]) { | |
| 227 | 228 | const p = Buffer.prototype; | |
| 228 | 229 | const lowerFn = fn.replace(/UInt/, 'Uint'); | |
0 commit comments