Commit 2abdcbb
deps: V8: cherry-pick f2d92ec
Original commit message:
[base] Add missing include of <type_traits>
The missing include causes compilation failures for node.js, see
#30020.
It's not great to have includes in a file called "macros.h", but we
define several functions there that make use of type traits. Fixing
that is a separate project.
R=mlippautz@chromium.org
Change-Id: Idb067679e597521230f94eb8c99f1347ed3808cb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868622
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64386}
Refs: v8/v8@f2d92ec
Backport-PR-URL: #30513
PR-URL: #30020
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent 4638361 commit 2abdcbb
2 files changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -39,7 +39,7 @@ | |||
| 39 | 39 | ||
| 40 | 40 | # Reset this number to 0 on major V8 upgrades. | |
| 41 | 41 | # Increment by one for each non-official patch applied to deps/v8. | |
| 42 | - 'v8_embedder_string': '-node.8', | ||
| 42 | + 'v8_embedder_string': '-node.9', | ||
| 43 | 43 | ||
| 44 | 44 | ##### V8 defaults for Node.js ##### | |
| 45 | 45 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,6 +6,7 @@ | |||
| 6 | 6 | #define V8_BASE_MACROS_H_ | |
| 7 | 7 | ||
| 8 | 8 | #include <limits> | |
| 9 | + #include <type_traits> | ||
| 9 | 10 | ||
| 10 | 11 | #include "src/base/compiler-specific.h" | |
| 11 | 12 | #include "src/base/logging.h" | |
0 commit comments