url: throw error if argument length of revokeObjectURL is 0 · nodejs/node@2acbcbd · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 2acbcbd

Browse filesBrowse the repository at this point in the historyBrowse files

DylanTet

authored and

richardlau

committed

url: throw error if argument length of revokeObjectURL is 0

Added a check to see if url wasn't included as an argument which will then throw an error. Fixes: #50432 PR-URL: #50433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

1 parent 450163c commit 2acbcbd
Copy full SHA for 2acbcbd

2 files changed

+18Lines changed: 18 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • url.js
• test/parallel
  • test-url-revokeobjecturl.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/url.js‎

Copy file name to clipboardExpand all lines: lib/internal/url.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1100,6 +1100,10 @@ function installObjectURLMethods() {
1100	1100	}
1101	1101
1102	1102	function revokeObjectURL(url) {
	1103	+ if (arguments.length === 0) {
	1104	+ throw new ERR_MISSING_ARGS('url');
	1105	+ }
	1106	+
1103	1107	bindingBlob.revokeObjectURL(`${url}`);
1104	1108	}
1105	1109

Collapse file

‎test/parallel/test-url-revokeobjecturl.js‎

Copy file name to clipboard

+14Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,14 @@
	1	+ 'use strict';
	2	+
	3	+ require('../common');
	4	+
	5	+ // Test ensures that the function receives the url argument.
	6	+
	7	+ const assert = require('node:assert');
	8	+
	9	+ assert.throws(() => {
	10	+ URL.revokeObjectURL();
	11	+ }, {
	12	+ code: 'ERR_MISSING_ARGS',
	13	+ name: 'TypeError',
	14	+ });

0 commit comments

Comments

0 (0)