Commit 2b12bca
src: use context-free V8 message column getters
PR-URL: #62778
Refs: https://issues.chromium.org/issues/42210793
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>1 parent f454d17 commit 2b12bca
2 files changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -677,7 +677,7 @@ class NodeInspectorClient : public V8InspectorClient { | |||
| 677 | 677 | ToInspectorString(isolate, message->Get())->string(), | |
| 678 | 678 | ToInspectorString(isolate, message->GetScriptResourceName())->string(), | |
| 679 | 679 | message->GetLineNumber(context).FromMaybe(0), | |
| 680 | - message->GetStartColumn(context).FromMaybe(0), | ||
| 680 | + message->GetStartColumn(), | ||
| 681 | 681 | client_->createStackTrace(stack_trace), | |
| 682 | 682 | script_id); | |
| 683 | 683 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -65,7 +65,7 @@ static std::string GetSourceMapErrorSource(Isolate* isolate, | |||
| 65 | 65 | // the source texts. | |
| 66 | 66 | Local<Value> script_resource_name = message->GetScriptResourceName(); | |
| 67 | 67 | int linenum = message->GetLineNumber(context).FromJust(); | |
| 68 | - int columnum = message->GetStartColumn(context).FromJust(); | ||
| 68 | + int columnum = message->GetStartColumn(); | ||
| 69 | 69 | ||
| 70 | 70 | Local<Value> argv[] = {script_resource_name, | |
| 71 | 71 | v8::Int32::New(isolate, linenum), | |
@@ -148,8 +148,8 @@ static std::string GetErrorSource(Isolate* isolate, | |||
| 148 | 148 | int script_start = (linenum - origin.LineOffset()) == 1 | |
| 149 | 149 | ? origin.ColumnOffset() | |
| 150 | 150 | : 0; | |
| 151 | - int start = message->GetStartColumn(context).FromMaybe(0); | ||
| 152 | - int end = message->GetEndColumn(context).FromMaybe(0); | ||
| 151 | + int start = message->GetStartColumn(); | ||
| 152 | + int end = message->GetEndColumn(); | ||
| 153 | 153 | if (start >= script_start) { | |
| 154 | 154 | CHECK_GE(end, start); | |
| 155 | 155 | start -= script_start; | |
0 commit comments