Commit 2b1e7c2
build: compile with C++20 support on Windows
Our Linux build infra is not ready for it yet,
but V8 is making it difficult to compile on Windows
without it.
Refs: #45402
PR-URL: #52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent 5bde9e6 commit 2b1e7c2
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -286,7 +286,8 @@ | |||
| 286 | 286 | 'VCCLCompilerTool': { | |
| 287 | 287 | 'AdditionalOptions': [ | |
| 288 | 288 | '/Zc:__cplusplus', | |
| 289 | - '-std:c++17' | ||
| 289 | + # The following option enables c++20 on Windows. This is needed for V8 v12.4+ | ||
| 290 | + '-std:c++20', | ||
| 290 | 291 | ], | |
| 291 | 292 | 'BufferSecurityCheck': 'true', | |
| 292 | 293 | 'DebugInformationFormat': 1, # /Z7 embed info in .obj files | |
0 commit comments