build: optimized and fixed building configuration to Android · nodejs/node@2b89d11 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 2b89d11

Browse filesBrowse the repository at this point in the historyBrowse files

MeowShe

authored and

danielleadams

committed

build: optimized and fixed building configuration to Android

PR-URL: #44016 Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>

1 parent eded43c commit 2b89d11
Copy full SHA for 2b89d11

1 file changed

+3-5Lines changed: 3 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• android-configure

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎android-configure‎

Copy file name to clipboardExpand all lines: android-configure

+3-5Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -17,16 +17,14 @@ NDK_PATH=$1
17	17	ARCH="$2"
18	18	ANDROID_SDK_VERSION=$3
19	19
20		- if [ $ANDROID_SDK_VERSION -lt 23 ]; then
21		- echo "$ANDROID_SDK_VERSION should equal or later than 23(Android 6.0)"
	20	+ if [ $ANDROID_SDK_VERSION -lt 24 ]; then
	21	+ echo "$ANDROID_SDK_VERSION should equal or later than 24 (Android 7.0)"
22	22	fi
23	23
24		- CC_VER="4.9"
25		-
26	24	case $ARCH in
27	25	arm)
28	26	DEST_CPU="arm"
29		- TOOLCHAIN_NAME="armv7-linux-androideabi"
	27	+ TOOLCHAIN_NAME="armv7a-linux-androideabi"
30	28	;;
31	29	x86)
32	30	DEST_CPU="ia32"

0 commit comments

Comments

0 (0)