Commit 2bdc87c
committed
doc: update git node release example
And add additional info for security releases.
PR-URL: #58475
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>1 parent 28f9b43 commit 2bdc87c
1 file changed
Lines changed: 21 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -735,15 +735,34 @@ the build before moving forward. Use the following list as a baseline: | |||
| 735 | 735 | ### 11. Tag and sign the release commit | |
| 736 | 736 | ||
| 737 | 737 | Once you have produced builds that you're happy with you can either run | |
| 738 | - `git node release --promote` | ||
| 738 | + `git node release --promote`: | ||
| 739 | 739 | ||
| 740 | 740 | ```bash | |
| 741 | - git node release -S --promote https://github.com/nodejs/node/pull/XXXX | ||
| 741 | + git node release --promote https://github.com/nodejs/node/pull/XXXX -S | ||
| 742 | 742 | ``` | |
| 743 | 743 | ||
| 744 | 744 | to automate the remaining steps until step 16 or you can perform it manually | |
| 745 | 745 | following the below steps. | |
| 746 | 746 | ||
| 747 | + <details> | ||
| 748 | + <summary>Security release</summary> | ||
| 749 | + | ||
| 750 | + For security releases, NCU should be configured to target the public repository, | ||
| 751 | + not the private one where the proposal are hosted. Pass the upstream where to | ||
| 752 | + fetch the proposal from using the `--fetch-from` flag. | ||
| 753 | + | ||
| 754 | + When promoting several releases, you can pass multiple URLs: | ||
| 755 | + | ||
| 756 | + ```bash | ||
| 757 | + git node release --promote \ | ||
| 758 | + --fetch-from git@github.com:nodejs-private/node-private.git \ | ||
| 759 | + https://github.com/nodejs-private/node-private/pull/XXXX \ | ||
| 760 | + https://github.com/nodejs-private/node-private/pull/XXXX \ | ||
| 761 | + -S | ||
| 762 | + ``` | ||
| 763 | + | ||
| 764 | + </details> | ||
| 765 | + | ||
| 747 | 766 | *** | |
| 748 | 767 | ||
| 749 | 768 | Create a new tag: By waiting until this stage to create tags, you can discard | |
0 commit comments