Commit 2c651ce
doc: fix typos and grammar in BUILDING.md & onboarding.md
PR-URL: #61267
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>1 parent 1b15453 commit 2c651ce
2 files changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -635,7 +635,7 @@ on Linux, you can try [Docker](https://www.docker.com/products/docker-desktop/) | |||
| 635 | 635 | (using an image like `gengjiawen/node-build:2020-02-14`). | |
| 636 | 636 | ||
| 637 | 637 | The `--debug` is not necessary and will slow down build and testing, but it can | |
| 638 | - show clear stacktrace if ASan hits an issue. | ||
| 638 | + show a clear stack trace if ASan hits an issue. | ||
| 639 | 639 | ||
| 640 | 640 | ```bash | |
| 641 | 641 | ./configure --debug --enable-asan && make -j4 | |
@@ -713,8 +713,8 @@ the number of parallel build tasks (`-j<n>`). | |||
| 713 | 713 | ||
| 714 | 714 | #### Tips | |
| 715 | 715 | ||
| 716 | - You may need disable vcpkg integration if you got link error about symbol | ||
| 717 | - redefine related to zlib.lib(zlib1.dll), even you never install it by hand, | ||
| 716 | + You may need to disable vcpkg integration if you encounter a link error about symbol | ||
| 717 | + redefinition related to zlib.lib(zlib1.dll), even if you never installed it by hand, | ||
| 718 | 718 | as vcpkg is part of CLion and Visual Studio now. | |
| 719 | 719 | ||
| 720 | 720 | ```powershell | |
@@ -889,7 +889,7 @@ cp c:\ccache\ccache.exe c:\ccache\cl.exe | |||
| 889 | 889 | ``` | |
| 890 | 890 | ||
| 891 | 891 | With newer version of Visual Studio, it may need the copy to be `clang-cl.exe` | |
| 892 | - instead. If the output of `vcbuild.bat` suggestion missing `clang-cl.exe`, copy | ||
| 892 | + instead. If the output of `vcbuild.bat` suggests missing `clang-cl.exe`, copy | ||
| 893 | 893 | it differently: | |
| 894 | 894 | ||
| 895 | 895 | ```powershell | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -286,7 +286,7 @@ needs to be pointed out separately during the onboarding. | |||
| 286 | 286 | * If you are interested in helping to fix coverity reports consider requesting | |
| 287 | 287 | access to the projects coverity project as outlined in [static-analysis][]. | |
| 288 | 288 | * If you are interested in helping out with CI reliability, check out the | |
| 289 | - [reliability respository][] and [guide on how to deal with CI flakes][]. | ||
| 289 | + [reliability repository][] and [guide on how to deal with CI flakes][]. | ||
| 290 | 290 | ||
| 291 | 291 | [Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md | |
| 292 | 292 | [Labels]: doc/contributing/collaborator-guide.md#labels | |
@@ -299,7 +299,7 @@ needs to be pointed out separately during the onboarding. | |||
| 299 | 299 | [`node-test-pull-request`]: https://ci.nodejs.org/job/node-test-pull-request/ | |
| 300 | 300 | [guide on how to deal with CI flakes]: https://github.com/nodejs/test?tab=readme-ov-file#protocols-in-improving-ci-reliability | |
| 301 | 301 | [participants' expenses]: https://github.com/openjs-foundation/cross-project-council/blob/main/community-fund/COMMUNITY_FUND_POLICY.md#community-fund-rules | |
| 302 | - [reliability respository]: https://github.com/nodejs/reliability | ||
| 302 | + [reliability repository]: https://github.com/nodejs/reliability | ||
| 303 | 303 | [set up the credentials]: https://github.com/nodejs/node-core-utils#setting-up-github-credentials | |
| 304 | 304 | [static-analysis]: doc/contributing/static-analysis.md | |
| 305 | 305 | [two-factor authentication]: https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/ | |
0 commit comments