Commit 2c6cf90
deps: V8: cherry-pick 50031fae736f
Original commit message:
[compiler] Explicitly initialize const members
This fixes a compilation error in Node.js with Xcode:
initialize the const member 'blueprint_'.
error: constructor for 'v8::internal::compiler::Callee' must explicitly
Change-Id: Ia55398428d0de35a9ad5132eabd22d0adb694514
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1895561
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64719}
Refs: v8/v8@50031fa
Backport-PR-URL: #30513
PR-URL: #30020
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent 1e5e8c3 commit 2c6cf90
2 files changed
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -39,7 +39,7 @@ | |||
| 39 | 39 | ||
| 40 | 40 | # Reset this number to 0 on major V8 upgrades. | |
| 41 | 41 | # Increment by one for each non-official patch applied to deps/v8. | |
| 42 | - 'v8_embedder_string': '-node.18', | ||
| 42 | + 'v8_embedder_string': '-node.19', | ||
| 43 | 43 | ||
| 44 | 44 | ##### V8 defaults for Node.js ##### | |
| 45 | 45 | ||
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -387,8 +387,10 @@ class CompilationSubject { | |||
| 387 | 387 | // always has a FunctionBlueprint. | |
| 388 | 388 | class Callee { | |
| 389 | 389 | public: | |
| 390 | - explicit Callee(Handle<JSFunction> jsfunction) : jsfunction_(jsfunction) {} | ||
| 391 | - explicit Callee(FunctionBlueprint const& blueprint) : blueprint_(blueprint) {} | ||
| 390 | + explicit Callee(Handle<JSFunction> jsfunction) | ||
| 391 | + : jsfunction_(jsfunction), blueprint_() {} | ||
| 392 | + explicit Callee(FunctionBlueprint const& blueprint) | ||
| 393 | + : jsfunction_(), blueprint_(blueprint) {} | ||
| 392 | 394 | ||
| 393 | 395 | Handle<SharedFunctionInfo> shared(Isolate* isolate) const { | |
| 394 | 396 | return blueprint_.has_value() | |
0 commit comments