Commit 2c84601
util: don't init Debug if it's not needed yet
Because any call to util.inspect() with an object results in
inspectPromise() being called, Debug was being initialized even when
it's not needed. Instead, the initialization is placed after the
isPromise check.
PR-URL: #8452
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>1 parent f854d8c commit 2c84601
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -231,10 +231,10 @@ function ensureDebugIsInitialized() { | |||
| 231 | 231 | ||
| 232 | 232 | ||
| 233 | 233 | function inspectPromise(p) { | |
| 234 | - ensureDebugIsInitialized(); | ||
| 235 | 234 | // Only create a mirror if the object is a Promise. | |
| 236 | 235 | if (!binding.isPromise(p)) | |
| 237 | 236 | return null; | |
| 237 | + ensureDebugIsInitialized(); | ||
| 238 | 238 | const mirror = Debug.MakeMirror(p, true); | |
| 239 | 239 | return {status: mirror.status(), value: mirror.promiseValue().value_}; | |
| 240 | 240 | } | |
0 commit comments