http: remove redundant keepAliveTimeoutBuffer assignment · nodejs/node@2c94967 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 2c94967

Browse filesBrowse the repository at this point in the historyBrowse files

efekrskl

authored and

aduh95

committed

http: remove redundant keepAliveTimeoutBuffer assignment

PR-URL: #61743 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

1 parent c4f298c commit 2c94967
Copy full SHA for 2c94967

1 file changed

-6Lines changed: 0 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • _http_server.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/_http_server.js‎

Copy file name to clipboardExpand all lines: lib/_http_server.js

-6Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -576,12 +576,6 @@ function Server(options, requestListener) {
576	576
577	577	storeHTTPOptions.call(this, options);
578	578
579		- // Optional buffer added to the keep-alive timeout when setting socket timeouts.
580		- // Helps reduce ECONNRESET errors from clients by extending the internal timeout.
581		- // Default is 1000ms if not specified.
582		- const buf = options.keepAliveTimeoutBuffer;
583		- this.keepAliveTimeoutBuffer =
584		- (typeof buf === 'number' && NumberIsFinite(buf) && buf >= 0) ? buf : 1000;
585	579	net.Server.call(
586	580	this,
587	581	{ allowHalfOpen: true, noDelay: options.noDelay ?? true,

0 commit comments

Comments

0 (0)