Commit 2ce4b7c
build: do not depend on cp in PATH
Use gyp’s own copying mechanism instead.
It’s not really clear which UNIX utils exactly are needed to build on
Windows, but this is an easier fix (at least for me) than figuring
out how to get `cp` into the `PATH` in all cases, and judging
from the issue I’m not the only one who ran into this.
Fixes: #20272
PR-URL: #20296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 701f536 commit 2ce4b7c
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -680,13 +680,13 @@ | |||
| 680 | 680 | 'toolsets': ['host'], | |
| 681 | 681 | 'conditions': [ | |
| 682 | 682 | [ 'v8_enable_inspector==1', { | |
| 683 | - 'actions': [ | ||
| 683 | + 'copies': [ | ||
| 684 | 684 | { | |
| 685 | - 'action_name': 'v8_inspector_copy_protocol_to_intermediate_folder', | ||
| 686 | - 'inputs': [ 'deps/v8/src/inspector/js_protocol.pdl' ], | ||
| 687 | - 'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl' ], | ||
| 688 | - 'action': [ 'cp', '<@(_inputs)', '<(SHARED_INTERMEDIATE_DIR)' ], | ||
| 689 | - }, | ||
| 685 | + 'destination': '<(SHARED_INTERMEDIATE_DIR)', | ||
| 686 | + 'files': ['deps/v8/src/inspector/js_protocol.pdl'] | ||
| 687 | + } | ||
| 688 | + ], | ||
| 689 | + 'actions': [ | ||
| 690 | 690 | { | |
| 691 | 691 | 'action_name': 'v8_inspector_convert_protocol_to_json', | |
| 692 | 692 | 'inputs': [ | |
0 commit comments