doc: remove "maintenance is supported by" text in BUILDING.md · nodejs/node@2d16a74 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 2d16a74

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

MylesBorins

committed

doc: remove "maintenance is supported by" text in BUILDING.md

The "maintenance is supported by" stuff in BUILDING.md is unclear. It seems unnecessary so I propose removing it. I don't understand what it means to, in this context, support maintenance. Does it mean that you simply do the maintenance? Does that mean it really just means "maintain"? Do we really mean that we mantain support, rather than support maintenance? That information does not seem necessary to include. I'm not sure it's meaningful. With (for example) Windows, is it accurate to say that the Node.js core team maintains support for it? Or is it accurate to say that support is maintaned by smaller groups or individuals within the Node.js core team? Both could be considered accurate. So is the difference meaningful? I think the more important elements of determinig tier support are the other listed elements. PR-URL: #30365 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent 39d0a25 commit 2d16a74
Copy full SHA for 2d16a74

1 file changed

+6-9Lines changed: 6 additions & 9 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• BUILDING.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎BUILDING.md‎

Copy file name to clipboardExpand all lines: BUILDING.md

+6-9Lines changed: 6 additions & 9 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -69,17 +69,14 @@ There are three support tiers:
69	69
70	70	* **Tier 1**: These platforms represent the majority of Node.js users. The
71	71	Node.js Build Working Group maintains infrastructure for full test coverage.
72		- Maintenance is supported by the Node.js core team. All commits to the
73		- Node.js repository are tested on multiple variants of these platforms. Test
74		- failures on tier 1 platforms will block releases.
	72	+ All commits to the Node.js repository are tested on multiple variants of these
	73	+ platforms. Test failures on tier 1 platforms will block releases.
75	74	* **Tier 2**: These platforms represent smaller segments of the Node.js user
76	75	base. The Node.js Build Working Group maintains infrastructure for full test
77		- coverage. Maintenance is supported by smaller groups or individuals within
78		- the Node.js core team, or the vendor of the platform itself. All commits to
79		- the Node.js repository are tested on multiple variants of these platforms
80		- where practical. Test failures on tier 2 platforms will block releases.
81		- Delays in release of binaries for these platforms are acceptable
82		- where necessary due to infrastructure concerns.
	76	+ coverage. All commits to the Node.js repository are tested on multiple
	77	+ variants of these platforms where practical. Test failures on tier 2 platforms
	78	+ will block releases. Delays in release of binaries for these platforms are
	79	+ acceptable where necessary due to infrastructure concerns.
83	80	* **Experimental**: May not compile or test suite may not pass. The core team
84	81	does not create releases for these platforms. Test failures on experimental
85	82	platforms do not block releases. Contributions to improve support for these

0 commit comments

Comments

0 (0)