Commit 2d503b1
debugger: display array contents in repl
This commit allows all array properties to be printed except for
"length". Previously, this filter was applied by checking the
type of each property. However, something changed in V8, and
array elements started coming through as numeric strings, which
stopped them from being displayed.
Fixes: #6444
PR-URL: #6448
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>1 parent 5fe5fa2 commit 2d503b1
2 files changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -548,8 +548,8 @@ Client.prototype.mirrorObject = function(handle, depth, cb) { | |||
| 548 | 548 | mirrorValue = '[?]'; | |
| 549 | 549 | } | |
| 550 | 550 | ||
| 551 | - if (Array.isArray(mirror) && typeof prop.name !== 'number') { | ||
| 552 | - // Skip the 'length' property. | ||
| 551 | + // Skip the 'length' property. | ||
| 552 | + if (Array.isArray(mirror) && prop.name === 'length') { | ||
| 553 | 553 | return; | |
| 554 | 554 | } | |
| 555 | 555 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -75,3 +75,7 @@ addTest('for (var i in process.env) delete process.env[i]', []); | |||
| 75 | 75 | addTest('process.env', [ | |
| 76 | 76 | /\{\}/ | |
| 77 | 77 | ]); | |
| 78 | + | ||
| 79 | + addTest('arr = [{foo: "bar"}]', [ | ||
| 80 | + /\[ \{ foo: 'bar' \} \]/ | ||
| 81 | + ]); | ||
0 commit comments