Commit 2d5cb3b
build: fail on CI if leftover processes
If any tests leave processes running after testing results are complete,
fail the test run.
PR-URL: #11269
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>1 parent 6bf9366 commit 2d5cb3b
1 file changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -212,13 +212,23 @@ test-ci-js: | |||
| 212 | 212 | $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \ | |
| 213 | 213 | --mode=release --flaky-tests=$(FLAKY_TESTS) \ | |
| 214 | 214 | $(TEST_CI_ARGS) $(CI_JS_SUITES) | |
| 215 | + # Clean up any leftover processes | ||
| 216 | + PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \ | ||
| 217 | + if [ "$${PS_OUT}" ]; then \ | ||
| 218 | + echo $${PS_OUT} | $(XARGS) kill; exit 1; \ | ||
| 219 | + fi | ||
| 215 | 220 | ||
| 216 | 221 | test-ci: LOGLEVEL := info | |
| 217 | 222 | test-ci: | build-addons | |
| 218 | 223 | out/Release/cctest --gtest_output=tap:cctest.tap | |
| 219 | 224 | $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \ | |
| 220 | 225 | --mode=release --flaky-tests=$(FLAKY_TESTS) \ | |
| 221 | 226 | $(TEST_CI_ARGS) $(CI_NATIVE_SUITES) $(CI_JS_SUITES) | |
| 227 | + # Clean up any leftover processes | ||
| 228 | + PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \ | ||
| 229 | + if [ "$${PS_OUT}" ]; then \ | ||
| 230 | + echo $${PS_OUT} | $(XARGS) kill; exit 1; \ | ||
| 231 | + fi | ||
| 222 | 232 | ||
| 223 | 233 | test-release: test-build | |
| 224 | 234 | $(PYTHON) tools/test.py --mode=release | |
0 commit comments