Commit 2e0ef36
doc: simplify text in pull-requests.md
Mostly, this replaces "It is recommended to do X" with "Do X."
PR-URL: #30458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 11d0170 commit 2e0ef36
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -73,7 +73,7 @@ $ git remote add upstream https://github.com/nodejs/node.git | |||
| 73 | 73 | $ git fetch upstream | |
| 74 | 74 | ``` | |
| 75 | 75 | ||
| 76 | - It is recommended to configure `git` so that it knows who you are: | ||
| 76 | + Configure `git` so that it knows who you are: | ||
| 77 | 77 | ||
| 78 | 78 | ```text | |
| 79 | 79 | $ git config user.name "J. Random User" | |
@@ -125,7 +125,7 @@ For contributing C++ code, you may want to look at the | |||
| 125 | 125 | ||
| 126 | 126 | ### Step 4: Commit | |
| 127 | 127 | ||
| 128 | - It is a recommended best practice to keep your changes as logically grouped | ||
| 128 | + It is a best practice to keep your changes as logically grouped | ||
| 129 | 129 | as possible within individual commits. There is no limit to the number of | |
| 130 | 130 | commits any single Pull Request may have, and many contributors find it easier | |
| 131 | 131 | to review changes that are split across multiple commits. | |
0 commit comments