Commit 2e100c8
test: remove literals that obscure assert messages
Remove string literals as messages to `assert.strictEqual()`. They can
be misleading here (where perhaps the reason an assertino failed isn't
that the deleter wasn't called but rather was called too many times.
Backport-PR-URL: #19265
PR-URL: #17642
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent 077e187 commit 2e100c8
1 file changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -9,14 +9,13 @@ assert.strictEqual(binding.newBuffer().toString(), binding.theText); | |||
| 9 | 9 | assert.strictEqual(binding.newExternalBuffer().toString(), binding.theText); | |
| 10 | 10 | console.log('gc1'); | |
| 11 | 11 | global.gc(); | |
| 12 | - assert.strictEqual(binding.getDeleterCallCount(), 1, 'deleter was not called'); | ||
| 12 | + assert.strictEqual(binding.getDeleterCallCount(), 1); | ||
| 13 | 13 | assert.strictEqual(binding.copyBuffer().toString(), binding.theText); | |
| 14 | 14 | ||
| 15 | 15 | let buffer = binding.staticBuffer(); | |
| 16 | - assert.strictEqual(binding.bufferHasInstance(buffer), true, | ||
| 17 | - 'buffer type checking fails'); | ||
| 16 | + assert.strictEqual(binding.bufferHasInstance(buffer), true); | ||
| 18 | 17 | assert.strictEqual(binding.bufferInfo(buffer), true); | |
| 19 | 18 | buffer = null; | |
| 20 | 19 | global.gc(); | |
| 21 | 20 | console.log('gc2'); | |
| 22 | - assert.strictEqual(binding.getDeleterCallCount(), 2, 'deleter was not called'); | ||
| 21 | + assert.strictEqual(binding.getDeleterCallCount(), 2); | ||
0 commit comments