Commit 2e6a66d
src: address 3 useless call coverity warnings
Fix the last 3 useless call reports from coverity
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #42426
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent 6c13988 commit 2e6a66d
3 files changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -215,10 +215,10 @@ void InspectorConsoleCall(const FunctionCallbackInfo<Value>& info) { | |||
| 215 | 215 | ||
| 216 | 216 | Local<Value> node_method = info[1]; | |
| 217 | 217 | CHECK(node_method->IsFunction()); | |
| 218 | - node_method.As<Function>()->Call(context, | ||
| 218 | + USE(node_method.As<Function>()->Call(context, | ||
| 219 | 219 | info.Holder(), | |
| 220 | 220 | call_args.length(), | |
| 221 | - call_args.out()).FromMaybe(Local<Value>()); | ||
| 221 | + call_args.out())); | ||
| 222 | 222 | } | |
| 223 | 223 | ||
| 224 | 224 | static void* GetAsyncTask(int64_t asyncId) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2646,7 +2646,6 @@ void Http2Session::New(const FunctionCallbackInfo<Value>& args) { | |||
| 2646 | 2646 | static_cast<SessionType>( | |
| 2647 | 2647 | args[0]->Int32Value(env->context()).ToChecked()); | |
| 2648 | 2648 | Http2Session* session = new Http2Session(state, args.This(), type); | |
| 2649 | - session->get_async_id(); // avoid compiler warning | ||
| 2650 | 2649 | Debug(session, "session created"); | |
| 2651 | 2650 | } | |
| 2652 | 2651 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1666,7 +1666,7 @@ void Parse(Environment* env, | |||
| 1666 | 1666 | null, // fragment defaults to null | |
| 1667 | 1667 | }; | |
| 1668 | 1668 | SetArgs(env, argv, url); | |
| 1669 | - cb->Call(context, recv, arraysize(argv), argv).FromMaybe(Local<Value>()); | ||
| 1669 | + USE(cb->Call(context, recv, arraysize(argv), argv)); | ||
| 1670 | 1670 | } else if (error_cb->IsFunction()) { | |
| 1671 | 1671 | Local<Value> flags = Integer::NewFromUnsigned(isolate, url.flags); | |
| 1672 | 1672 | USE(error_cb.As<Function>()->Call(context, recv, 1, &flags)); | |
0 commit comments