Commit 2e766a6
console: add Symbol.toStringTag property
Add Symbol.toStringTag property to console object to follow WPT changes
Update WPT status of console and the repl test case
Refs: web-platform-tests/wpt#24717
PR-URL: #35399
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent ae14923 commit 2e766a6
2 files changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -17,6 +17,7 @@ const { | |||
| 17 | 17 | ReflectOwnKeys, | |
| 18 | 18 | Symbol, | |
| 19 | 19 | SymbolHasInstance, | |
| 20 | + SymbolToStringTag, | ||
| 20 | 21 | WeakMap, | |
| 21 | 22 | } = primordials; | |
| 22 | 23 | ||
@@ -228,6 +229,12 @@ ObjectDefineProperties(Console.prototype, { | |||
| 228 | 229 | ...consolePropAttributes, | |
| 229 | 230 | value: groupIndentation | |
| 230 | 231 | }, | |
| 232 | + [SymbolToStringTag]: { | ||
| 233 | + writable: false, | ||
| 234 | + enumerable: false, | ||
| 235 | + configurable: true, | ||
| 236 | + value: 'console' | ||
| 237 | + } | ||
| 231 | 238 | }); | |
| 232 | 239 | } | |
| 233 | 240 | }, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -757,7 +757,7 @@ const errorTests = [ | |||
| 757 | 757 | { | |
| 758 | 758 | send: 'console', | |
| 759 | 759 | expect: [ | |
| 760 | - '{', | ||
| 760 | + 'Object [console] {', | ||
| 761 | 761 | ' log: [Function: log],', | |
| 762 | 762 | ' warn: [Function: warn],', | |
| 763 | 763 | ' dir: [Function: dir],', | |
0 commit comments