test: account for truthy signal in flaky async_hooks tests · nodejs/node@2e8570b · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 631
• Pull requests 747
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 2e8570b

Browse filesBrowse the repository at this point in the historyBrowse files

RaisinTen

authored and

aduh95

committed

test: account for truthy signal in flaky async_hooks tests

When the spawned child process gets closed with a signal, the exit code is not set and that is why the exit code assertion was failing. This change adjusts the test to check the signal and if it is truthy, it doesn't assert the exit code and instead logs the signal and continues the rest of the assertions. Refs: #58463 (comment) Refs: #58199 Refs: #58463 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58478 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 0105c13 commit 2e8570b
Copy full SHA for 2e8570b

2 files changed

+12-4Lines changed: 12 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/async-hooks
  • test-emit-after-on-destroyed.js
  • test-improper-unwind.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/async-hooks/test-emit-after-on-destroyed.js‎

Copy file name to clipboardExpand all lines: test/async-hooks/test-emit-after-on-destroyed.js

+6-2Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -52,8 +52,12 @@ if (process.argv[2] === 'child') {
52	52	child.stderr.on('data', (d) => { errData = Buffer.concat([ errData, d ]); });
53	53	child.stdout.on('data', (d) => { outData = Buffer.concat([ outData, d ]); });
54	54
55		- child.on('close', common.mustCall((code) => {
56		- assert.strictEqual(code, 1);
	55	+ child.on('close', common.mustCall((code, signal) => {
	56	+ if (signal) {
	57	+ console.log(`Child closed with signal: ${signal}`);
	58	+ } else {
	59	+ assert.strictEqual(code, 1);
	60	+ }
57	61	assert.match(outData.toString(), heartbeatMsg,
58	62	'did not crash until we reached offending line of code ' +
59	63	`(found ${outData})`);

Collapse file

‎test/async-hooks/test-improper-unwind.js‎

Copy file name to clipboardExpand all lines: test/async-hooks/test-improper-unwind.js

+6-2Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -55,8 +55,12 @@ if (process.argv[2] === 'child') {
55	55	child.stderr.on('data', (d) => { errData = Buffer.concat([ errData, d ]); });
56	56	child.stdout.on('data', (d) => { outData = Buffer.concat([ outData, d ]); });
57	57
58		- child.on('close', common.mustCall((code) => {
59		- assert.strictEqual(code, 1);
	58	+ child.on('close', common.mustCall((code, signal) => {
	59	+ if (signal) {
	60	+ console.log(`Child closed with signal: ${signal}`);
	61	+ } else {
	62	+ assert.strictEqual(code, 1);
	63	+ }
60	64	assert.match(outData.toString(), heartbeatMsg,
61	65	'did not crash until we reached offending line of code ' +
62	66	`(found ${outData})`);

0 commit comments

Comments

0 (0)