Commit 2f036c8
test: s390x z15 accelerated zlib fixes
Modern s390x x15 has accelerated zlib operations on the CPU. Many
distros currently have patches to take advantage of this feature. One
side-effect of these patches is that compression routine is no longer
deterministic as with software. Interruption to input produces
different compressed results. Invalid input can result in processor
fault.
PR-URL: #44117
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent 5d5971c commit 2f036c8
3 files changed
Lines changed: 5 additions & 3 deletions
File tree
- test/parallel
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -53,7 +53,7 @@ const input = Buffer.from([0x78, 0xBB, 0x04, 0x09, 0x01, 0xA5]); | |||
| 53 | 53 | stream.on('error', common.mustCall(function(err) { | |
| 54 | 54 | // It's not possible to separate invalid dict and invalid data when using | |
| 55 | 55 | // the raw format | |
| 56 | - assert.match(err.message, /invalid/); | ||
| 56 | + assert.match(err.message, /(invalid|Operation-Ending-Supplemental Code is 0x12)/); | ||
| 57 | 57 | })); | |
| 58 | 58 | ||
| 59 | 59 | stream.write(input); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -16,7 +16,7 @@ zipper.write('A'.repeat(17000)); | |||
| 16 | 16 | zipper.flush(); | |
| 17 | 17 | ||
| 18 | 18 | let received = 0; | |
| 19 | - unzipper.on('data', common.mustCall((d) => { | ||
| 19 | + unzipper.on('data', common.mustCallAtLeast((d) => { | ||
| 20 | 20 | received += d.length; | |
| 21 | 21 | }, 2)); | |
| 22 | 22 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -55,7 +55,9 @@ const expectedBase64Gzip = 'H4sIAAAAAAAAA11RS05DMQy8yhzg6d2BPSAkJPZu4laWkjiN4' + | |||
| 55 | 55 | 'sHnHNzRtagj5AQAA'; | |
| 56 | 56 | ||
| 57 | 57 | zlib.deflate(inputString, common.mustCall((err, buffer) => { | |
| 58 | - assert.strictEqual(buffer.toString('base64'), expectedBase64Deflate); | ||
| 58 | + zlib.inflate(buffer, common.mustCall((err, inflated) => { | ||
| 59 | + assert.strictEqual(inflated.toString(), inputString); | ||
| 60 | + })); | ||
| 59 | 61 | })); | |
| 60 | 62 | ||
| 61 | 63 | zlib.gzip(inputString, common.mustCall((err, buffer) => { | |
0 commit comments