test: use mustCall in place of countdown in timers test · nodejs/node@2f73e6e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 636
• Pull requests 762
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 2f73e6e

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

MylesBorins

committed

test: use mustCall in place of countdown in timers test

Use common.mustCall() in place of countdown in test-timers-immediate-unref. PR-URL: #32416 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent 6f06cf0 commit 2f73e6e
Copy full SHA for 2f73e6e

1 file changed

+2-6Lines changed: 2 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-timers-immediate-unref.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-timers-immediate-unref.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-timers-immediate-unref.js

+2-6Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -1,8 +1,6 @@
1	1	'use strict';
2	2
3	3	const common = require('../common');
4		- const Countdown = require('../common/countdown');
5		-
6	4	const assert = require('assert');
7	5
8	6	const immediate = setImmediate(() => {});
@@ -16,12 +14,10 @@ clearImmediate(immediate);
16	14	setImmediate(common.mustCall(firstStep)).ref().unref().unref().ref();
17	15
18	16	function firstStep() {
19		- const countdown =
20		- new Countdown(2, common.mustCall(() => setImmediate(secondStep)));
21	17	// Unrefed setImmediate executes if it was unrefed but something else keeps
22	18	// the loop open
23		- setImmediate(() => countdown.dec()).unref();
24		- setTimeout(() => countdown.dec(), 50);
	19	+ setImmediate(common.mustCall()).unref();
	20	+ setTimeout(common.mustCall(() => { setImmediate(secondStep); }), 0);
25	21	}
26	22
27	23	function secondStep() {

0 commit comments

Comments

0 (0)