repl: check for precise values rather than falsy in loops · nodejs/node@301a4f8 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 301a4f8

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

BethGriggs

committed

repl: check for precise values rather than falsy in loops

This prepares the code for the no-cond-assign ESLint rule. PR-URL: #41614 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent 0e35d01 commit 301a4f8
Copy full SHA for 301a4f8

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • repl.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/repl.js‎

Copy file name to clipboardExpand all lines: lib/repl.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -381,7 +381,7 @@ function REPLServer(prompt,
381	381	paused = false;
382	382	let entry;
383	383	const tmpCompletionEnabled = self.isCompletionEnabled;
384		- while (entry = ArrayPrototypeShift(pausedBuffer)) {
	384	+ while ((entry = ArrayPrototypeShift(pausedBuffer)) !== undefined) {
385	385	const { 0: type, 1: payload, 2: isCompletionEnabled } = entry;
386	386	switch (type) {
387	387	case 'key': {
@@ -1450,7 +1450,7 @@ function complete(line, callback) {
1450	1450	ArrayPrototypePush(completionGroups,
1451	1451	getGlobalLexicalScopeNames(this[kContextId]));
1452	1452	let contextProto = this.context;
1453		- while (contextProto = ObjectGetPrototypeOf(contextProto)) {
	1453	+ while ((contextProto = ObjectGetPrototypeOf(contextProto)) !== null) {
1454	1454	ArrayPrototypePush(completionGroups,
1455	1455	filteredOwnPropertyNames(contextProto));
1456	1456	}

0 commit comments

Comments

0 (0)