Commit 30837b3
test: improve check in test-os
The check for `os.networkInterfaces()` in `test-os.js` may be too
strict. It's apparently possible for a machine to be configured with
multiple IPv4 loopback interfaces. Increase specificity of filter to
check on only the object we expect.
PR-URL: #14655
Fixes: #14654
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 55aba6a commit 30837b3
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -116,7 +116,8 @@ const interfaces = os.networkInterfaces(); | |||
| 116 | 116 | switch (platform) { | |
| 117 | 117 | case 'linux': | |
| 118 | 118 | { | |
| 119 | - const filter = (e) => e.address === '127.0.0.1'; | ||
| 119 | + const filter = | ||
| 120 | + (e) => e.address === '127.0.0.1' && e.netmask === '255.0.0.0'; | ||
| 120 | 121 | const actual = interfaces.lo.filter(filter); | |
| 121 | 122 | const expected = [{ address: '127.0.0.1', netmask: '255.0.0.0', | |
| 122 | 123 | mac: '00:00:00:00:00:00', family: 'IPv4', | |
0 commit comments