Commit 308b6bc
authored
async_hooks: move asyncResource property on bound function to EOL
PR-URL: #58618
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent 2eeb65f commit 308b6bc
3 files changed
Lines changed: 6 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3583,15 +3583,18 @@ In a future version of Node.js, [`message.headers`][], | |||
| 3583 | 3583 | ||
| 3584 | 3584 | <!-- YAML | |
| 3585 | 3585 | changes: | |
| 3586 | + - version: REPLACEME | ||
| 3587 | + pr-url: https://github.com/nodejs/node/pull/58618 | ||
| 3588 | + description: End-of-Life. | ||
| 3586 | 3589 | - version: v20.0.0 | |
| 3587 | 3590 | pr-url: https://github.com/nodejs/node/pull/46432 | |
| 3588 | 3591 | description: Runtime-deprecation. | |
| 3589 | 3592 | --> | |
| 3590 | 3593 | ||
| 3591 | - Type: Runtime | ||
| 3594 | + Type: End-of-Life | ||
| 3592 | 3595 | ||
| 3593 | - In a future version of Node.js, the `asyncResource` property will no longer | ||
| 3594 | - be added when a function is bound to an `AsyncResource`. | ||
| 3596 | + Older versions of Node.js would add the `asyncResource` when a function is | ||
| 3597 | + bound to an `AsyncResource`. It no longer does. | ||
| 3595 | 3598 | ||
| 3596 | 3599 | ### DEP0173: the `assert.CallTracker` class | |
| 3597 | 3600 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -20,7 +20,6 @@ const { | |||
| 20 | 20 | ERR_INVALID_ASYNC_ID, | |
| 21 | 21 | } = require('internal/errors').codes; | |
| 22 | 22 | const { | |
| 23 | - deprecate, | ||
| 24 | 23 | kEmptyObject, | |
| 25 | 24 | } = require('internal/util'); | |
| 26 | 25 | const { | |
@@ -247,7 +246,6 @@ class AsyncResource { | |||
| 247 | 246 | } else { | |
| 248 | 247 | bound = FunctionPrototypeBind(this.runInAsyncScope, this, fn, thisArg); | |
| 249 | 248 | } | |
| 250 | - let self = this; | ||
| 251 | 249 | ObjectDefineProperties(bound, { | |
| 252 | 250 | 'length': { | |
| 253 | 251 | __proto__: null, | |
@@ -256,17 +254,6 @@ class AsyncResource { | |||
| 256 | 254 | value: fn.length, | |
| 257 | 255 | writable: false, | |
| 258 | 256 | }, | |
| 259 | - 'asyncResource': { | ||
| 260 | - __proto__: null, | ||
| 261 | - configurable: true, | ||
| 262 | - enumerable: true, | ||
| 263 | - get: deprecate(function() { | ||
| 264 | - return self; | ||
| 265 | - }, 'The asyncResource property on bound functions is deprecated', 'DEP0172'), | ||
| 266 | - set: deprecate(function(val) { | ||
| 267 | - self = val; | ||
| 268 | - }, 'The asyncResource property on bound functions is deprecated', 'DEP0172'), | ||
| 269 | - }, | ||
| 270 | 257 | }); | |
| 271 | 258 | return bound; | |
| 272 | 259 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -25,7 +25,6 @@ const fn2 = asyncResource.bind((a, b) => { | |||
| 25 | 25 | return executionAsyncId(); | |
| 26 | 26 | }); | |
| 27 | 27 | ||
| 28 | - assert.strictEqual(fn2.asyncResource, asyncResource); | ||
| 29 | 28 | assert.strictEqual(fn2.length, 2); | |
| 30 | 29 | ||
| 31 | 30 | setImmediate(() => { | |
0 commit comments