Commit 30d783f
src: stop tracing agent before shutting down libuv
Otherwise there might be pending tracing fs writes which lead to a crash
because the libuv threadpool is already gone.
Fixes: #46376
PR-URL: #46380
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent c0d3fda commit 30d783f
1 file changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -797,6 +797,10 @@ void DefaultProcessExitHandler(Environment* env, int exit_code) { | |||
| 797 | 797 | env->set_can_call_into_js(false); | |
| 798 | 798 | env->stop_sub_worker_contexts(); | |
| 799 | 799 | env->isolate()->DumpAndResetStats(); | |
| 800 | + // The tracing agent could be in the process of writing data using the | ||
| 801 | + // threadpool. Stop it before shutting down libuv. The rest of the tracing | ||
| 802 | + // agent disposal will be performed in DisposePlatform(). | ||
| 803 | + per_process::v8_platform.StopTracingAgent(); | ||
| 800 | 804 | // When the process exits, the tasks in the thread pool may also need to | |
| 801 | 805 | // access the data of V8Platform, such as trace agent, or a field | |
| 802 | 806 | // added in the future. So make sure the thread pool exits first. | |
0 commit comments