Commit 3115041
authored
cli: remove --no-experimental-fetch flag
PR-URL: #52611
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>1 parent 01c281f commit 3115041
6 files changed
Lines changed: 4 additions & 42 deletions
File tree
- doc
- api
- lib/internal/process
- src
- test/parallel
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1364,14 +1364,6 @@ added: v0.8.0 | |||
| 1364 | 1364 | ||
| 1365 | 1365 | Silence deprecation warnings. | |
| 1366 | 1366 | ||
| 1367 | - ### `--no-experimental-fetch` | ||
| 1368 | - | ||
| 1369 | - <!-- YAML | ||
| 1370 | - added: v18.0.0 | ||
| 1371 | - --> | ||
| 1372 | - | ||
| 1373 | - Disable exposition of [Fetch API][] on the global scope. | ||
| 1374 | - | ||
| 1375 | 1367 | ### `--no-experimental-global-customevent` | |
| 1376 | 1368 | ||
| 1377 | 1369 | <!-- YAML | |
@@ -2690,7 +2682,6 @@ one is included in the list below. | |||
| 2690 | 2682 | * `--network-family-autoselection-attempt-timeout` | |
| 2691 | 2683 | * `--no-addons` | |
| 2692 | 2684 | * `--no-deprecation` | |
| 2693 | - * `--no-experimental-fetch` | ||
| 2694 | 2685 | * `--no-experimental-global-customevent` | |
| 2695 | 2686 | * `--no-experimental-global-navigator` | |
| 2696 | 2687 | * `--no-experimental-repl-await` | |
@@ -3166,7 +3157,6 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12 | |||
| 3166 | 3157 | [DEP0025 warning]: deprecations.md#dep0025-requirenodesys | |
| 3167 | 3158 | [ECMAScript module]: esm.md#modules-ecmascript-modules | |
| 3168 | 3159 | [ExperimentalWarning: `vm.measureMemory` is an experimental feature]: vm.md#vmmeasurememoryoptions | |
| 3169 | - [Fetch API]: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API | ||
| 3170 | 3160 | [File System Permissions]: permissions.md#file-system-permissions | |
| 3171 | 3161 | [Loading ECMAScript modules using `require()`]: modules.md#loading-ecmascript-modules-using-require | |
| 3172 | 3162 | [Module customization hooks]: module.md#customization-hooks | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -183,9 +183,6 @@ Use this flag to enable ShadowRealm support. | |||
| 183 | 183 | .It Fl -experimental-test-coverage | |
| 184 | 184 | Enable code coverage in the test runner. | |
| 185 | 185 | . | |
| 186 | - .It Fl -no-experimental-fetch | ||
| 187 | - Disable experimental support for the Fetch API. | ||
| 188 | - . | ||
| 189 | 186 | .It Fl -no-experimental-websocket | |
| 190 | 187 | Disable experimental support for the WebSocket API. | |
| 191 | 188 | . | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -103,7 +103,7 @@ function prepareExecution(options) { | |||
| 103 | 103 | setupInspectorHooks(); | |
| 104 | 104 | setupNavigator(); | |
| 105 | 105 | setupWarningHandler(); | |
| 106 | - setupUndici(); | ||
| 106 | + setupWebsocket(); | ||
| 107 | 107 | setupCustomEvent(); | |
| 108 | 108 | setupCodeCoverage(); | |
| 109 | 109 | setupDebugEnv(); | |
@@ -308,17 +308,8 @@ function setupWarningHandler() { | |||
| 308 | 308 | } | |
| 309 | 309 | } | |
| 310 | 310 | ||
| 311 | - // https://fetch.spec.whatwg.org/ | ||
| 312 | 311 | // https://websockets.spec.whatwg.org/ | |
| 313 | - function setupUndici() { | ||
| 314 | - if (getOptionValue('--no-experimental-fetch')) { | ||
| 315 | - delete globalThis.fetch; | ||
| 316 | - delete globalThis.FormData; | ||
| 317 | - delete globalThis.Headers; | ||
| 318 | - delete globalThis.Request; | ||
| 319 | - delete globalThis.Response; | ||
| 320 | - } | ||
| 321 | - | ||
| 312 | + function setupWebsocket() { | ||
| 322 | 313 | if (getOptionValue('--no-experimental-websocket')) { | |
| 323 | 314 | delete globalThis.WebSocket; | |
| 324 | 315 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -396,11 +396,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() { | |||
| 396 | 396 | &EnvironmentOptions::enable_source_maps, | |
| 397 | 397 | kAllowedInEnvvar); | |
| 398 | 398 | AddOption("--experimental-abortcontroller", "", NoOp{}, kAllowedInEnvvar); | |
| 399 | - AddOption("--experimental-fetch", | ||
| 400 | - "experimental Fetch API", | ||
| 401 | - &EnvironmentOptions::experimental_fetch, | ||
| 402 | - kAllowedInEnvvar, | ||
| 403 | - true); | ||
| 399 | + AddOption("--experimental-fetch", "", NoOp{}, kAllowedInEnvvar); | ||
| 404 | 400 | AddOption("--experimental-websocket", | |
| 405 | 401 | "experimental WebSocket API", | |
| 406 | 402 | &EnvironmentOptions::experimental_websocket, | |
This file was deleted.
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -99,6 +99,7 @@ const undocumented = difference(process.allowedNodeEnvironmentFlags, | |||
| 99 | 99 | assert(undocumented.delete('--debug-arraybuffer-allocations')); | |
| 100 | 100 | assert(undocumented.delete('--no-debug-arraybuffer-allocations')); | |
| 101 | 101 | assert(undocumented.delete('--es-module-specifier-resolution')); | |
| 102 | + assert(undocumented.delete('--experimental-fetch')); | ||
| 102 | 103 | assert(undocumented.delete('--experimental-global-webcrypto')); | |
| 103 | 104 | assert(undocumented.delete('--experimental-report')); | |
| 104 | 105 | assert(undocumented.delete('--experimental-worker')); | |
0 commit comments