Commit 318328f
committed
test: improve unexpected warnings error
If someone adds an `expectsWarning` listener without handling all
warning triggered in that test file, it'll result in a cryptic error
message. This improves the situation by providing an explicit error
about the unexpected warning.
PR-URL: #28138
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 084ffd8 commit 318328f
1 file changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -528,7 +528,15 @@ let catchWarning; | |||
| 528 | 528 | function expectWarning(nameOrMap, expected, code) { | |
| 529 | 529 | if (catchWarning === undefined) { | |
| 530 | 530 | catchWarning = {}; | |
| 531 | - process.on('warning', (warning) => catchWarning[warning.name](warning)); | ||
| 531 | + process.on('warning', (warning) => { | ||
| 532 | + if (!catchWarning[warning.name]) { | ||
| 533 | + throw new TypeError( | ||
| 534 | + `"${warning.name}" was triggered without being expected.\n` + | ||
| 535 | + util.inspect(warning) | ||
| 536 | + ); | ||
| 537 | + } | ||
| 538 | + catchWarning[warning.name](warning); | ||
| 539 | + }); | ||
| 532 | 540 | } | |
| 533 | 541 | if (typeof nameOrMap === 'string') { | |
| 534 | 542 | catchWarning[nameOrMap] = _expectWarning(nameOrMap, expected, code); | |
0 commit comments