Commit 318d683
doc: use imperative in COLLABORATOR_GUIDE
Instead of wording the paragraph about communicating deprecations with
the ecosystem as if it were directed at the ecosystem, write it as in
imperative directed at the collaborator, since that is the audience for
the COLLABORATOR_GUIDE. Instead of assuring the reader that a best
effort will be made, instruct the reader to make the effort to
communicate with the ecosystem.
PR-URL: #21340
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent 177a7c0 commit 318d683
1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -463,11 +463,11 @@ Runtime Deprecation cycle. However, there is no requirement that deprecated | |||
| 463 | 463 | code must progress ultimately to *End-of-Life*. Documentation-only and runtime | |
| 464 | 464 | deprecations may remain indefinitely. | |
| 465 | 465 | ||
| 466 | - A best effort will be made to communicate pending deprecations and associated | ||
| 467 | - mitigations with the ecosystem as soon as possible (preferably before the pull | ||
| 468 | - request adding the deprecation lands on the master branch). All deprecations | ||
| 469 | - included in a Node.js release should be listed prominently in the "Notable | ||
| 470 | - Changes" section of the release notes. | ||
| 466 | + Communicate pending deprecations and associated mitigations with the ecosystem | ||
| 467 | + as soon as possible (preferably before the pull request adding the deprecation | ||
| 468 | + lands on the master branch). Use the `notable-change` label on all pull requests | ||
| 469 | + that add a new deprecation or move an existing deprecation to a new deprecation | ||
| 470 | + level. | ||
| 471 | 471 | ||
| 472 | 472 | ### Involving the TSC | |
| 473 | 473 | ||
0 commit comments