Commit 318e2c7
deps: libuv: cherry-pick aabb7651de
Original commit message:
win: properly initialize OSVERSIONINFOW (#5107)
Otherwise calling `RtlGetVersion()` might produce UB. Problem was
causing random crashes in the node.js test suite with stack traces
like this one:
```
node.exe!__report_gsfailure(unsigned __int64 stack_cookie) Line 220
at D:\a\_work\1\s\src\vctools\crt\vcstartup\src\gs\gs_report.c(220)
...
```
Fixes: libuv/libuv#5106
Refs: libuv/libuv@aabb765
PR-URL: #62561
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>1 parent c6ccbd7 commit 318e2c7
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -56,6 +56,8 @@ static int minimal_windows10_version1709(void) { | |||
| 56 | 56 | OSVERSIONINFOW os_info; | |
| 57 | 57 | if (!pRtlGetVersion) | |
| 58 | 58 | return 0; | |
| 59 | + os_info.dwOSVersionInfoSize = sizeof(os_info); | ||
| 60 | + os_info.szCSDVersion[0] = L'\0'; | ||
| 59 | 61 | pRtlGetVersion(&os_info); | |
| 60 | 62 | if (os_info.dwMajorVersion < 10) | |
| 61 | 63 | return 0; | |
0 commit comments