Commit 31d89c4
test: avoid repeated writes in watch helper
Use performFileOperation() for test runner watch updates so the
run() API path schedules a single delayed write instead of rewriting
the file until the second run completes.
Repeated writes can trigger another watch restart while the previous
rerun is still active. The runner then terminates the in-flight child
process with SIGTERM, which can make the captured output include both
a failed file-level subtest and the next successful run.
Also count only root summary duration lines when detecting completed
runs.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
PR-URL: #63386
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>1 parent 6f3587c commit 31d89c4
1 file changed
Lines changed: 6 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -106,7 +106,7 @@ async function testRunnerWatch({ | |||
| 106 | 106 | child.stdout.on('data', (data) => { | |
| 107 | 107 | stdout += data.toString(); | |
| 108 | 108 | currentRun += data.toString(); | |
| 109 | - const testRuns = stdout.match(/duration_ms\s\d+/g); | ||
| 109 | + const testRuns = stdout.match(/^\S+ duration_ms\s\d+/gm); | ||
| 110 | 110 | if (testRuns?.length >= 1) ran1.resolve(); | |
| 111 | 111 | if (testRuns?.length >= 2) ran2.resolve(); | |
| 112 | 112 | }); | |
@@ -118,18 +118,11 @@ async function testRunnerWatch({ | |||
| 118 | 118 | const content = fixtureContent[fileToUpdate]; | |
| 119 | 119 | const path = fixturePaths[fileToUpdate]; | |
| 120 | 120 | ||
| 121 | - if (useRunApi) { | ||
| 122 | - const interval = setInterval( | ||
| 123 | - () => writeFileSync(path, content), | ||
| 124 | - common.platformTimeout(1000), | ||
| 125 | - ); | ||
| 126 | - await ran2.promise; | ||
| 127 | - clearInterval(interval); | ||
| 128 | - } else { | ||
| 129 | - writeFileSync(path, content); | ||
| 130 | - await setTimeout(common.platformTimeout(1000)); | ||
| 131 | - await ran2.promise; | ||
| 132 | - } | ||
| 121 | + await performFileOperation( | ||
| 122 | + () => writeFileSync(path, content), | ||
| 123 | + useRunApi, | ||
| 124 | + ); | ||
| 125 | + await ran2.promise; | ||
| 133 | 126 | ||
| 134 | 127 | runs.push(currentRun); | |
| 135 | 128 | child.kill(); | |
0 commit comments