Commit 32b03d0
lib: add TLSSocket default error handler
This prevents the server from crashing due to an unhandled rejection
when a TLSSocket connection is abruptly destroyed during initialization
and the user has not attached an error handler to the socket.
e.g:
```js
const server = http2.createSecureServer({ ... })
server.on('secureConnection', socket => {
socket.on('error', err => {
console.log(err)
})
})
```
PR-URL: nodejs-private/node-private#750
Backport-PR-URL: #61044
Fixes: #44751
Refs: https://hackerone.com/bugs?subject=nodejs&report_id=3262404
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
CVE-ID: CVE-2025-59465
Refs: #576431 parent 4ef7a6c commit 32b03d0
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1252,6 +1252,7 @@ function tlsConnectionListener(rawSocket) { | |||
| 1252 | 1252 | socket[kErrorEmitted] = false; | |
| 1253 | 1253 | socket.on('close', onSocketClose); | |
| 1254 | 1254 | socket.on('_tlsError', onSocketTLSError); | |
| 1255 | + socket.on('error', onSocketTLSError); | ||
| 1255 | 1256 | } | |
| 1256 | 1257 | ||
| 1257 | 1258 | // AUTHENTICATION MODES | |
0 commit comments