Commit 32cf344
src: readlink("/proc/self/exe") -> uv_exename()
This commit also adds error handling. A THP-enabled build terminated
with an out-of-memory error on a system without /proc because it cast
the -1 from readlink() to size_t (i.e. ULONG_MAX) and then tried to
allocate a string of that size.
PR-URL: #28333
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent a28db5f commit 32cf344
1 file changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -115,8 +115,12 @@ static struct text_region FindNodeTextRegion() { | |||
| 115 | 115 | std::string exename; | |
| 116 | 116 | { | |
| 117 | 117 | char selfexe[PATH_MAX]; | |
| 118 | - ssize_t count = readlink("/proc/self/exe", selfexe, PATH_MAX); | ||
| 119 | - exename = std::string(selfexe, count); | ||
| 118 | + | ||
| 119 | + size_t size = sizeof(selfexe); | ||
| 120 | + if (uv_exepath(selfexe, &size)) | ||
| 121 | + return nregion; | ||
| 122 | + | ||
| 123 | + exename = std::string(selfexe, size); | ||
| 120 | 124 | } | |
| 121 | 125 | ||
| 122 | 126 | while (std::getline(ifs, map_line)) { | |
0 commit comments