Commit 32e5c39
committed
src: fix crash with SyntheticModule#setExport
Use the new non-deprecated V8 API for that.
PR-URL: #30062
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 42c4560 commit 32e5c39
2 files changed
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1500,7 +1500,7 @@ void ModuleWrap::SetSyntheticExport( | |||
| 1500 | 1500 | Local<Value> export_value = args[1]; | |
| 1501 | 1501 | ||
| 1502 | 1502 | Local<Module> module = obj->module_.Get(isolate); | |
| 1503 | - module->SetSyntheticModuleExport(export_name, export_value); | ||
| 1503 | + USE(module->SetSyntheticModuleExport(isolate, export_name, export_value)); | ||
| 1504 | 1504 | } | |
| 1505 | 1505 | ||
| 1506 | 1506 | void ModuleWrap::Initialize(Local<Object> target, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,8 +36,6 @@ const assert = require('assert'); | |||
| 36 | 36 | }); | |
| 37 | 37 | } | |
| 38 | 38 | ||
| 39 | - // https://bugs.chromium.org/p/v8/issues/detail?id=9828 | ||
| 40 | - /* | ||
| 41 | 39 | { | |
| 42 | 40 | const s = new SyntheticModule([], () => {}); | |
| 43 | 41 | await s.link(() => {}); | |
@@ -47,7 +45,6 @@ const assert = require('assert'); | |||
| 47 | 45 | name: 'ReferenceError', | |
| 48 | 46 | }); | |
| 49 | 47 | } | |
| 50 | - */ | ||
| 51 | 48 | ||
| 52 | 49 | { | |
| 53 | 50 | const s = new SyntheticModule([], () => {}); | |
0 commit comments