Revert "http: make HEAD method to work with keep-alive" · nodejs/node@336571f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 336571f

Browse filesBrowse the repository at this point in the historyBrowse files

targos

committed

Revert "http: make HEAD method to work with keep-alive"

This reverts commit 7afa533. The change breaks clients like cURL. Fixes: #38922 PR-URL: #38949 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

1 parent ec3e5b4 commit 336571f
Copy full SHA for 336571f

2 files changed

+1-53Lines changed: 1 addition & 53 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • _http_outgoing.js
• test/parallel
  • test-http-reuse-socket.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/_http_outgoing.js‎

Copy file name to clipboardExpand all lines: lib/_http_outgoing.js

+1-2Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -459,8 +459,7 @@ function _storeHeader(firstLine, headers) {
459	459	}
460	460
461	461	if (!state.contLen && !state.te) {
462		- if (!this._hasBody && (this.statusCode === 204 ||
463		- this.statusCode === 304)) {
	462	+ if (!this._hasBody) {
464	463	// Make sure we don't end the 0\r\n\r\n at the end of the message.
465	464	this.chunkedEncoding = false;
466	465	} else if (!this.useChunkedEncodingByDefault) {

Collapse file

‎test/parallel/test-http-reuse-socket.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-reuse-socket.js

-51Lines changed: 0 additions & 51 deletions

This file was deleted.

0 commit comments

Comments

0 (0)